DOC fix reconstruct_torch.py example by calling detach #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #826 +/- ##
=======================================
Coverage 88.03% 88.03%
=======================================
Files 64 64
Lines 2323 2323
=======================================
Hits 2045 2045
Misses 278 278
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@lylyhan ? your input is valued |
|
i approve this! sorry for the delay |
lostanlen
approved these changes
Jun 11, 2022
janden
approved these changes
Jun 13, 2022
eickenberg
pushed a commit
that referenced
this pull request
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an example from erroring out due to not detaching tensors from the computational graph before converting to numpy.
This goes a small way of solving #817