Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Use tight_layout to prevent plot axes from overlapping one another #827

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

MuawizChaudhary
Copy link
Collaborator

This PR fixes plots in the 1d code from overlapping one another.

From plot_real_signal.py.
Figure_2
Figure_2_fixed

From plot_synthetic.py.
Figure_3
Figure_3_fixed

This goes a small way of solving #817

@codecov-commenter
Copy link

Codecov Report

Merging #827 (d188601) into dev (ca9073f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #827   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files          64       64           
  Lines        2323     2323           
=======================================
  Hits         2045     2045           
  Misses        278      278           
Flag Coverage Δ
jenkins_main 88.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca9073f...d188601. Read the comment docs.

Copy link
Collaborator

@lostanlen lostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done @MuawizChaudhary

examples/1d/plot_real_signal.py Outdated Show resolved Hide resolved
@MuawizChaudhary
Copy link
Collaborator Author

@janden lemme know if its all good

@MuawizChaudhary MuawizChaudhary requested a review from janden June 11, 2022 19:48
@MuawizChaudhary MuawizChaudhary merged commit 1f63a98 into kymatio:dev Jun 14, 2022
eickenberg pushed a commit that referenced this pull request Jul 5, 2022
#827)

* DOC use tight_layout to prevent plot axes from overlapping one another

* STY moved plt.tight_layout() just above plt.show()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants