DOC Remove warning from sklearn example. #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #828 +/- ##
=======================================
Coverage 88.03% 88.03%
=======================================
Files 64 64
Lines 2323 2323
=======================================
Hits 2045 2045
Misses 278 278
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
lostanlen
approved these changes
Jun 2, 2022
eickenberg
pushed a commit
that referenced
this pull request
Jul 5, 2022
* DOC scaling scattering features improves performance from 95.88 to 97.55 * DOC increasing number of max_iter removes warning
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Esteemed Colleagues,
please accept my State of the Art (SOTA) result on the "Kymatio Sklearn Digit Recognition Benchmark" Benchmark.
Love,
ScatteringSepoy
To be much less trolly, this PR removes a warning thrown by sklearn about a lack of convergence, while keeping the same runtime and improving accuracy by about 1.5 percent.
This goes a small way of solving #817 .