Skip to content

DOC Remove warning from sklearn example. #828

Merged
edouardoyallon merged 2 commits intokymatio:devfrom
MuawizChaudhary:sklearn_sota
Jun 2, 2022
Merged

DOC Remove warning from sklearn example. #828
edouardoyallon merged 2 commits intokymatio:devfrom
MuawizChaudhary:sklearn_sota

Conversation

@MuawizChaudhary
Copy link
Collaborator

@MuawizChaudhary MuawizChaudhary commented Jun 2, 2022

Dear Esteemed Colleagues,

please accept my State of the Art (SOTA) result on the "Kymatio Sklearn Digit Recognition Benchmark" Benchmark.

Love,
ScatteringSepoy


To be much less trolly, this PR removes a warning thrown by sklearn about a lack of convergence, while keeping the same runtime and improving accuracy by about 1.5 percent.

This goes a small way of solving #817 .

@MuawizChaudhary MuawizChaudhary changed the base branch from master to dev June 2, 2022 03:09
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (ca9073f) to head (d851c67).
Report is 40 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #828   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files          64       64           
  Lines        2323     2323           
=======================================
  Hits         2045     2045           
  Misses        278      278           
Flag Coverage Δ
jenkins_main 88.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edouardoyallon edouardoyallon merged commit c5b8d67 into kymatio:dev Jun 2, 2022
eickenberg pushed a commit that referenced this pull request Jul 5, 2022
* DOC scaling scattering features improves performance from 95.88 to 97.55

* DOC increasing number of max_iter removes warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants