DOC Fix 3d example failing import#829
Merged
lostanlen merged 1 commit intokymatio:devfrom Jun 12, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #829 +/- ##
=======================================
Coverage 88.03% 88.03%
=======================================
Files 64 64
Lines 2323 2323
=======================================
Hits 2045 2045
Misses 278 278
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Collaborator
Author
|
The google colab has finished running. @eickenberg do the results look reasonable to you?
|
Collaborator
Author
|
Mind if we merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 3D example on dev fails an import due to the fact that we now use a class structure for the backend. This PR fixes this by importing instead the backend and calling compute integrals.
Currently in the process of running the full example on a google colab.
This goes a small way of solving #817 .