Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Fix 3d example failing import #829

Merged
merged 1 commit into from
Jun 12, 2022

Conversation

MuawizChaudhary
Copy link
Collaborator

The 3D example on dev fails an import due to the fact that we now use a class structure for the backend. This PR fixes this by importing instead the backend and calling compute integrals.

Currently in the process of running the full example on a google colab.

This goes a small way of solving #817 .

@codecov-commenter
Copy link

Codecov Report

Merging #829 (1f38623) into dev (ca9073f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #829   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files          64       64           
  Lines        2323     2323           
=======================================
  Hits         2045     2045           
  Misses        278      278           
Flag Coverage Δ
jenkins_main 88.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca9073f...1f38623. Read the comment docs.

@edouardoyallon edouardoyallon self-requested a review June 2, 2022 10:49
Copy link
Collaborator

@edouardoyallon edouardoyallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@MuawizChaudhary
Copy link
Collaborator Author

The google colab has finished running. @eickenberg do the results look reasonable to you?

image

Copy link
Collaborator

@janden janden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MuawizChaudhary
Copy link
Collaborator Author

Mind if we merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants