-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Fix 3d example failing import #829
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #829 +/- ##
=======================================
Coverage 88.03% 88.03%
=======================================
Files 64 64
Lines 2323 2323
=======================================
Hits 2045 2045
Misses 278 278
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
The google colab has finished running. @eickenberg do the results look reasonable to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Mind if we merge? |
The 3D example on dev fails an import due to the fact that we now use a class structure for the backend. This PR fixes this by importing instead the backend and calling compute integrals.
Currently in the process of running the full example on a google colab.
This goes a small way of solving #817 .