remove size_scattering kwarg from scattering1d#837
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #837 +/- ##
==========================================
+ Coverage 88.03% 88.05% +0.02%
==========================================
Files 64 64
Lines 2323 2311 -12
==========================================
- Hits 2045 2035 -10
+ Misses 278 276 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
as requested by @MuawizChaudhary
MuawizChaudhary
approved these changes
Jun 5, 2022
Collaborator
MuawizChaudhary
left a comment
MuawizChaudhary
left a comment
There was a problem hiding this comment.
I approve these changes.
Collaborator
Author
|
OK, please merge at your convenience. |
Collaborator
|
This passes the checks and it passes the test on my local system. I'm squashing and merging. |
lostanlen
added a commit
to lostanlen/kymatio
that referenced
this pull request
Jun 5, 2022
eickenberg
pushed a commit
that referenced
this pull request
Jul 5, 2022
* remove `size_scattering` kwarg from `scattering1d` Fixes #836 * dictionaries over several lines as requested by @MuawizChaudhary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #836
One kwarg less from
scattering1din base_frontend.py`Fewer LOCs, fewer repetitions