MAINT decouple scattering_filter_factory from ScatteringBase1D.build - #842
Merged
Merged
Conversation
lostanlen
changed the title
scattering_filter_factory from compute_minimum_support_to_padscattering_filter_factory from ScatteringBase1D.build
Codecov Report
@@ Coverage Diff @@
## dev #842 +/- ##
==========================================
- Coverage 88.05% 87.93% -0.12%
==========================================
Files 64 64
Lines 2311 2305 -6
==========================================
- Hits 2035 2027 -8
- Misses 276 278 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
MuawizChaudhary
changed the title
scattering_filter_factory from ScatteringBase1D.buildscattering_filter_factory from ScatteringBase1D.build
* remove compute_minimum_support_to_pad * bugfix previous commit (E IndexError: tuple index out of range) due to bad phi_f shape * update examples/1d/plot_filters * remove criterion_amplitude from self
remove fourth output argument (t_max_phi)
MuawizChaudhary
approved these changes
Jun 8, 2022
MuawizChaudhary
left a comment
MuawizChaudhary
left a comment
Collaborator
There was a problem hiding this comment.
tests pass on my end.
MuawizChaudhary
requested changes
Jun 8, 2022
MuawizChaudhary
left a comment
MuawizChaudhary
left a comment
Collaborator
There was a problem hiding this comment.
Sorry, didn't mean to approve.
requested by muawiz
MuawizChaudhary
approved these changes
Jun 8, 2022
eickenberg
pushed a commit
that referenced
this pull request
Jul 5, 2022
…ld` (#842) * remove call to compute_minimum_support_to_pad * remove criterion_amplitude from scattering_filter_factory * remove compute_minimum_support_to_pad * bugfix previous commit (E IndexError: tuple index out of range) due to bad phi_f shape * update examples/1d/plot_filters * remove criterion_amplitude from self * update test_Scattering1D_filter_factory_T remove fourth output argument (t_max_phi) * remove 4th output argument from scattering_filter_factory * remove an empty line requested by muawiz
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #840
scattering_filter_factoryshould not returnt_max_phiscattering1d/filter_bankmoduleScattering1Dconstructorcriterion_amplitudebeing passed toscattering_filter_factorycompute_minimum_support_to_padThe calls to scattering_filter_factory will require a rebase from #833