MAINT, STY Various ASV maintenance, style changes. #845
Merged
MuawizChaudhary merged 6 commits intokymatio:devfrom Jun 17, 2022
Merged
MAINT, STY Various ASV maintenance, style changes. #845MuawizChaudhary merged 6 commits intokymatio:devfrom
MuawizChaudhary merged 6 commits intokymatio:devfrom
Conversation
…ison between torch and torch_skcuda backends more fairer
lostanlen
approved these changes
Jun 6, 2022
Collaborator
|
see with @janden / @eickenberg about Jenkins deployment? |
janden
requested changes
Jun 10, 2022
janden
approved these changes
Jun 13, 2022
eickenberg
pushed a commit
that referenced
this pull request
Jul 5, 2022
* MAINT no need for cuda synchronization during filter generation * STY equal sign spacing * STY renaming devices to device on table to match with scattering2d * STY spacing * STY spacing * MAINT added torch.no_grad function decorators in order to make comparison between torch and torch_skcuda backends more fairer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request add's some style changes and removes some unneeded cuda synchronization.
I wanted to add some documentation, but turns out y'all already added documentation during the 2021 sprint.
I think all we need to do in terms of ASV related stuff is figure out how to integrate it into our continuous integration stack ;P