MAINT simplify compute_params_filterbank, remove _move_one_dyadic_step
#848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and remove _move_one_dyadic_step (WIP, off-by-one error)
* the elbow_xi - q/Q * elbow_xi formula was wrong * remove multiple assignments * define js at the end of the function by means of a map on get_max_dyadic_subsampling (this third output will be removed from the prototype later)
lostanlen
changed the title
compute_params_filterbank, remove and _move_one_dyadic_stepcompute_params_filterbank, remove _move_one_dyadic_step
MuawizChaudhary
approved these changes
Jun 8, 2022
kymatio/scattering1d/filter_bank.py
Outdated
| xis.append(elbow_xi - q/Q * elbow_xi) | ||
| sigmas.append(sigma_min) | ||
|
|
||
| js = list(map(get_max_dyadic_subsampling, xis, sigmas, repeat(alpha))) |
There was a problem hiding this comment.
i like this trick. I wonder if we could replace with a list comprehension tho.
by request from Muawiz
MuawizChaudhary
approved these changes
Jun 8, 2022
|
thank you so much @MuawizChaudhary !! |
eickenberg
pushed a commit
that referenced
this pull request
Jul 5, 2022
…step` (#848) * simplify compute_params_filterbank and remove _move_one_dyadic_step (WIP, off-by-one error) * bugfix previous commit * the elbow_xi - q/Q * elbow_xi formula was wrong * remove multiple assignments * define js at the end of the function by means of a map on get_max_dyadic_subsampling (this third output will be removed from the prototype later) * replace list-map by list comprehension by request from Muawiz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #847