MAINT remove calibrate_scattering_filters - #850
Merged
Conversation
lostanlen
changed the title
calibrate_scattering_filterscalibrate_scattering_filters
lostanlen
changed the title
calibrate_scattering_filterscalibrate_scattering_filters
Codecov Report
@@ Coverage Diff @@
## dev #850 +/- ##
==========================================
- Coverage 88.05% 88.01% -0.04%
==========================================
Files 64 64
Lines 2311 2312 +1
==========================================
Hits 2035 2035
- Misses 276 277 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
lostanlen
changed the title
calibrate_scattering_filterscalibrate_scattering_filters
eickenberg
pushed a commit
that referenced
this pull request
Jul 5, 2022
* move Q check to ScatteringBase1D.build * remove one call to calibrate_scattering_filters * write test_Q * sigma_min = sigma0 / math.pow(2, J_scattering) * update compute_meta_scattering prototype * update precompute_size_scattering prototype * remove calibrate_scattering_filters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #849
Another PR with more deletions than additions.
This PR adds some new input arguments to
precompute_size_scatteringandcompute_meta_scatteringbut i have a plan on how to remove them later while maintaining backwards compatibility. (#851)