avoid passing log2_T, pad, unpad to 1D core#860
Merged
MuawizChaudhary merged 1 commit intokymatio:devfrom Jun 9, 2022
Merged
Conversation
This was referenced Jun 9, 2022
eickenberg
pushed a commit
that referenced
this pull request
Jul 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #852
a lighter and better focused version of #855
unfortunately the same thing cannot be done in 2D right now because the logic is quite different:
self.padis a backend function which is being defined atbuildtime and takesself.shapeas input. It also depends upon a parameterpre_pad. It's almost like an object inside theScattering2Dobject.Next step for me is to remove
pad_leftand friends and perform padding/unpadding outside of scattering. We've discussed a plan with @MuawizChaudhary for that. (in the spirit of #735 )