Remove vectorize + write frontend-agnostic runtime checks#861
Merged
Conversation
use out_array='dict' instead !
MuawizChaudhary
approved these changes
Jun 9, 2022
Collaborator
MuawizChaudhary
left a comment
MuawizChaudhary
left a comment
There was a problem hiding this comment.
Pro merging once the Jenkins finishes building
Collaborator
|
hmmmm seems like the Jenkins aborted |
Collaborator
Author
|
but Jenkins passed on #862, which contains this PR ?! |
Collaborator
|
Tests pass on my end, dunno whats up with Jenkins here. |
eickenberg
pushed a commit
that referenced
this pull request
Jul 5, 2022
* avoid passing log2_T, pad, unpad to 1D core * remove vectorize from Scattering1D use out_array='dict' instead ! * finish removing vectorize Co-authored-by: Muawiz Sajjad Chaudhary <39755015+MuawizChaudhary@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #843
(a second attempt after some productive discussions during review of #844)
This is a planned change for v0.3
The default behavior is still
out_type="array"(vectorize=True)We introduce
out_type="dict"to replicate the behavior ofout_type="array", vectorize=FalseA net reduction in code size thanks to utility methods
_check_runtime_args()and_check_input()inScatteringBase1DWritten on top of #860. I suggest we look at #860 first
Tests pass locally
Note that vectorize is still documented in the base frontend. I'll take care of updating these docs after code review.