-
Notifications
You must be signed in to change notification settings - Fork 139
DOC Enable .to(device)
semantics for pytorch examples
#874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Enable .to(device)
semantics for pytorch examples
#874
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #874 +/- ##
======================================
Coverage ? 87.86%
======================================
Files ? 64
Lines ? 2250
Branches ? 0
======================================
Hits ? 1977
Misses ? 273
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful!
743748f
to
fbd8512
Compare
looking at the commit history... did i rebase all wrong Q_Q |
I'm fine with this, but your code isn't passing CI. |
Nm looks like it's the TF FFT implementation which is still flaky. |
* DOC enabled .to(device) semantics instead of .cuda() * DOC enable .to(device) semantics where there were none before in reconstruct_torch.py * DOC make cifar set of examples use to(device) semantics, make them use num_worker=4 * DOC enable .to(device) semantics in mnist torch example * DOC use torch.device in scattering3d example * DOC move .to(device) call
This PR enables
to(device)
semantics for the pytorch examples.This resolves issue #824 .