DOC Enable .to(device) semantics for pytorch examples#874
Merged
janden merged 7 commits intoJun 20, 2022
Conversation
Collaborator
Author
Codecov Report
@@ Coverage Diff @@
## dev #874 +/- ##
======================================
Coverage ? 87.86%
======================================
Files ? 64
Lines ? 2250
Branches ? 0
======================================
Hits ? 1977
Misses ? 273
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
janden
requested changes
Jun 13, 2022
MuawizChaudhary
force-pushed
the
enable_cuda_pytorch_examples
branch
from
743748f to
fbd8512
Compare
Collaborator
Author
|
looking at the commit history... did i rebase all wrong Q_Q |
janden
approved these changes
Jun 20, 2022
Collaborator
|
I'm fine with this, but your code isn't passing CI. |
Collaborator
|
Nm looks like it's the TF FFT implementation which is still flaky. |
eickenberg
pushed a commit
that referenced
this pull request
Jul 5, 2022
* DOC enabled .to(device) semantics instead of .cuda() * DOC enable .to(device) semantics where there were none before in reconstruct_torch.py * DOC make cifar set of examples use to(device) semantics, make them use num_worker=4 * DOC enable .to(device) semantics in mnist torch example * DOC use torch.device in scattering3d example * DOC move .to(device) call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables
to(device)semantics for the pytorch examples.This resolves issue #824 .