Skip to content

DOC Enable .to(device) semantics for pytorch examples #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 20, 2022

Conversation

MuawizChaudhary
Copy link
Collaborator

This PR enables to(device) semantics for the pytorch examples.

This resolves issue #824 .

@MuawizChaudhary MuawizChaudhary changed the base branch from master to dev June 12, 2022 04:14
@MuawizChaudhary
Copy link
Collaborator Author

We should really merge #829 , #826 before this.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2022

Codecov Report

❗ No coverage uploaded for pull request base (dev@6fc8547). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev     #874   +/-   ##
======================================
  Coverage       ?   87.86%           
======================================
  Files          ?       64           
  Lines          ?     2250           
  Branches       ?        0           
======================================
  Hits           ?     1977           
  Misses         ?      273           
  Partials       ?        0           
Flag Coverage Δ
jenkins_main 87.86% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fc8547...aaef062. Read the comment docs.

Copy link
Collaborator

@janden janden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

@MuawizChaudhary MuawizChaudhary force-pushed the enable_cuda_pytorch_examples branch from 743748f to fbd8512 Compare June 14, 2022 00:37
@MuawizChaudhary
Copy link
Collaborator Author

looking at the commit history... did i rebase all wrong Q_Q

@MuawizChaudhary MuawizChaudhary requested a review from janden June 17, 2022 04:41
@janden
Copy link
Collaborator

janden commented Jun 20, 2022

I'm fine with this, but your code isn't passing CI.

@janden
Copy link
Collaborator

janden commented Jun 20, 2022

Nm looks like it's the TF FFT implementation which is still flaky.

@janden janden merged commit 8617f23 into kymatio:dev Jun 20, 2022
eickenberg pushed a commit that referenced this pull request Jul 5, 2022
* DOC enabled .to(device) semantics instead of .cuda()

* DOC enable .to(device) semantics where there were none before in reconstruct_torch.py

* DOC make cifar set of examples use to(device) semantics, make them use num_worker=4

* DOC enable .to(device) semantics in mnist torch example

* DOC use torch.device in scattering3d example

* DOC move .to(device) call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants