move core 1D asserts to _check_filterbanks in ScatteringBase
#876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostanlen
changed the title
_check_filterbanks in ScatteringBase_check_filterbanks in ScatteringBase
MuawizChaudhary
requested changes
Jun 12, 2022
MuawizChaudhary
approved these changes
Jun 14, 2022
Collaborator
MuawizChaudhary
left a comment
MuawizChaudhary
left a comment
There was a problem hiding this comment.
I'm fine with merging if you are @janden
Codecov Report
@@ Coverage Diff @@
## dev #876 +/- ##
==========================================
+ Coverage 87.76% 87.80% +0.03%
==========================================
Files 64 64
Lines 2232 2238 +6
==========================================
+ Hits 1959 1965 +6
Misses 273 273
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Collaborator
Author
|
@changhongw @cyrusvahidi whoever sees this first, please approve and merge |
Collaborator
Author
|
this one goes in pair with #887 |
eickenberg
pushed a commit
that referenced
this pull request
Jul 5, 2022
#876) * write _check_filterbanks in ScatteringBase1D * Document _check_filterbanks better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #869 by @MuawizChaudhary
don't mind the title of the branch:
oversamplingis not becoming immutable.also don't mind the title of the commit:
_check_filterbanksbelongs inScatteringBase, notScatteringBase1D