Make Scattering1D compatible with TF>=2.5
#882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
not sure how i'm supposed to test that? create a new CI job? |
MuawizChaudhary
approved these changes
Jun 15, 2022
Collaborator
MuawizChaudhary
left a comment
MuawizChaudhary
left a comment
There was a problem hiding this comment.
I am immediately merging based on the fact that it fixes #775 and #801 (as seen in this notebook.) @janden you are welcome to look over the diff and make comments on it yourself, but given the severity of this issue impacting an entire frontend, I'm immediately merging. We can fix anything in a future PR.
Great work @lostanlen !
Comment on lines
95
to
+97
| for psi_f in psi1_f: | ||
| plt.plot(np.arange(N)/N, psi_f[0], 'b') | ||
|
|
||
| plt.plot(np.arange(N)/N, psi_f['levels'][0], 'b') |
Collaborator
There was a problem hiding this comment.
We can fix this later, but I dont see why this had to change lines.
This was referenced Jun 15, 2022
Collaborator
Author
|
2D, you're next |
This was referenced Jun 16, 2022
lostanlen
added a commit
to danedane-haider/kymatio
that referenced
this pull request
Jun 19, 2022
in light of kymatio#854 and kymatio#882 enable TeX rendering
lostanlen
added a commit
that referenced
this pull request
Jun 20, 2022
by Daniel Haider and Vincent Lostanlen approved by Muawiz Chaudhary and Joakim Andén * Update plot_filters.py * Update plot_filters.py * Update plot_filters.py Edits as required: - original formatting - line width reduction - psi <- psi_i * Update plot_filters.py * update examples/1d/plot_filters in light of #854 and #882 enable TeX rendering Co-authored-by: Vincent Lostanlen <vincent.lostanlen@ls2n.fr>
eickenberg
pushed a commit
that referenced
this pull request
Jul 5, 2022
* update plot_filters * update core * update filter_bank.py 1D * update torch_frontend.py 1D * simplify test_torch_scattering1d, circumvent a warning
eickenberg
pushed a commit
that referenced
this pull request
Jul 5, 2022
by Daniel Haider and Vincent Lostanlen approved by Muawiz Chaudhary and Joakim Andén * Update plot_filters.py * Update plot_filters.py * Update plot_filters.py Edits as required: - original formatting - line width reduction - psi <- psi_i * Update plot_filters.py * update examples/1d/plot_filters in light of #854 and #882 enable TeX rendering Co-authored-by: Vincent Lostanlen <vincent.lostanlen@ls2n.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in #775
done in duet with @MuawizChaudhary
ready for code review
i still need to update some docs
triaged for v0.3
once this PR passes code review, i'll work on 2D and 3D