Merged
Conversation
+ test_check_runtime_args
MuawizChaudhary
approved these changes
Jun 16, 2022
Collaborator
MuawizChaudhary
left a comment
MuawizChaudhary
left a comment
There was a problem hiding this comment.
Should oversampling be set by user?
Collaborator
Author
|
Yes. although i'll admit i don't love the current semantics. But these are discussions for another day. here the goal is to make sure that the value of oversampling is OK at runtime. |
Collaborator
Author
|
i've written this to complement #876. The new asserts rely on the assumption that oversampling>=0, but this wasnt being checked at runtime until now |
cyrusasfa
reviewed
Jun 18, 2022
cyrusasfa
reviewed
Jun 18, 2022
whitespace around operator
MuawizChaudhary
approved these changes
Jun 18, 2022
eickenberg
pushed a commit
that referenced
this pull request
Jul 5, 2022
* check oversampling in 1D + test_check_runtime_args * check that oversampling is integer whitespace around operator * remove auto indentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in
check_runtime_argsand write
test_check_runtime_args