MAINT HarmonicScattering3D now outputs real coefficients in Numpy. #889
Merged
Conversation
…p of print statements
…lex64 to np.float32
Codecov Report
@@ Coverage Diff @@
## dev #889 +/- ##
=======================================
Coverage 87.76% 87.76%
=======================================
Files 64 64
Lines 2232 2232
=======================================
Hits 1959 1959
Misses 273 273
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
janden
approved these changes
Jun 16, 2022
Collaborator
Author
|
Seeing as there are two reviewers that approve @janden would you like to do the honors of squashing and merging? |
eickenberg
pushed a commit
that referenced
this pull request
Jul 5, 2022
) * TST added tests confirming that #811 is an issue + some cleanup of print statements * MAINT change dtype of array defined in compute_integrals from np.complex64 to np.float32 * TST add type check tests for tensorflow suite of tests * TST added type checking for the torch suite of tests of 3d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #811 and adds a few tests confirming the fix.