MAINT make NumPy the default frontend#890
Merged
lostanlen merged 4 commits intokymatio:devfrom Jun 16, 2022
Merged
Conversation
janden
requested changes
Jun 16, 2022
Codecov Report
@@ Coverage Diff @@
## dev #890 +/- ##
==========================================
+ Coverage 87.76% 88.21% +0.44%
==========================================
Files 64 64
Lines 2232 2231 -1
==========================================
+ Hits 1959 1968 +9
+ Misses 273 263 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
janden
approved these changes
Jun 16, 2022
lostanlen
reviewed
Jun 16, 2022
lostanlen
reviewed
Jun 16, 2022
Collaborator
lostanlen
left a comment
lostanlen
left a comment
There was a problem hiding this comment.
just a nitpick about NumPy capitalization
lostanlen
changed the title
eickenberg
pushed a commit
that referenced
this pull request
Jul 5, 2022
* MAINT make Numpy the default frontend * TST fixed up tests and various imports * DOC documentation changes * STY Numpy to NumPy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #868, making Numpy the default frontend like we said we would.