Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT make NumPy the default frontend #890

Merged
merged 4 commits into from
Jun 16, 2022

Conversation

MuawizChaudhary
Copy link
Collaborator

This PR resolves #868, making Numpy the default frontend like we said we would.

@MuawizChaudhary MuawizChaudhary requested a review from janden June 16, 2022 05:53
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2022

Codecov Report

Merging #890 (e5a2c4d) into dev (88a806a) will increase coverage by 0.44%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #890      +/-   ##
==========================================
+ Coverage   87.76%   88.21%   +0.44%     
==========================================
  Files          64       64              
  Lines        2232     2231       -1     
==========================================
+ Hits         1959     1968       +9     
+ Misses        273      263      -10     
Flag Coverage Δ
jenkins_main 88.21% <100.00%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
kymatio/frontend/entry.py 100.00% <100.00%> (ø)
kymatio/torch.py 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88a806a...e5a2c4d. Read the comment docs.

Copy link
Collaborator

@lostanlen lostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nitpick about NumPy capitalization

@lostanlen lostanlen self-requested a review June 16, 2022 21:51
Copy link
Collaborator

@lostanlen lostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@lostanlen lostanlen changed the title MAINT make Numpy the default frontend MAINT make NumPy the default frontend Jun 16, 2022
@lostanlen lostanlen closed this Jun 16, 2022
@lostanlen lostanlen reopened this Jun 16, 2022
@lostanlen lostanlen merged commit c2a627f into kymatio:dev Jun 16, 2022
eickenberg pushed a commit that referenced this pull request Jul 5, 2022
* MAINT make Numpy the default frontend

* TST fixed up tests and various imports

* DOC documentation changes

* STY Numpy to NumPy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants