FIX include 'n' field in 1D/2D list + remove singleton dimension in 1D dict#900
Merged
changhongw merged 2 commits intokymatio:devfrom Jun 24, 2022
Merged
FIX include 'n' field in 1D/2D list + remove singleton dimension in 1D dict#900changhongw merged 2 commits intokymatio:devfrom
changhongw merged 2 commits intokymatio:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #900 +/- ##
==========================================
+ Coverage 88.14% 88.18% +0.04%
==========================================
Files 64 73 +9
Lines 2226 2294 +68
==========================================
+ Hits 1962 2023 +61
- Misses 264 271 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
MuawizChaudhary
approved these changes
Jun 23, 2022
Collaborator
|
@changhongw If you approve pls press the big green button! |
Collaborator
|
Thanks for noticing this problem! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #875, Fix #895
as discussed in today's Kymatio meeting
NB: these changes must be in the release notes.