Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX include 'n' field in 1D/2D list + remove singleton dimension in 1D dict #900

Merged
merged 2 commits into from
Jun 24, 2022

Conversation

lostanlen
Copy link
Collaborator

@lostanlen lostanlen commented Jun 23, 2022

Fix #875, Fix #895
as discussed in today's Kymatio meeting

NB: these changes must be in the release notes.

@codecov-commenter
Copy link

Codecov Report

Merging #900 (eee8d2e) into dev (511f1c3) will increase coverage by 0.04%.
The diff coverage is 82.71%.

@@            Coverage Diff             @@
##              dev     #900      +/-   ##
==========================================
+ Coverage   88.14%   88.18%   +0.04%     
==========================================
  Files          64       73       +9     
  Lines        2226     2294      +68     
==========================================
+ Hits         1962     2023      +61     
- Misses        264      271       +7     
Flag Coverage Δ
jenkins_main 88.18% <82.71%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
kymatio/frontend/entry.py 100.00% <ø> (ø)
kymatio/frontend/numpy_frontend.py 93.33% <ø> (-0.42%) ⬇️
kymatio/jax.py 0.00% <0.00%> (ø)
kymatio/scattering1d/frontend/numpy_frontend.py 70.27% <0.00%> (+1.84%) ⬆️
...matio/scattering1d/frontend/tensorflow_frontend.py 71.05% <0.00%> (+1.82%) ⬆️
kymatio/scattering2d/core/scattering2d.py 100.00% <ø> (ø)
kymatio/backend/numpy_backend.py 97.56% <50.00%> (-2.44%) ⬇️
kymatio/backend/jax_backend.py 90.00% <90.00%> (ø)
kymatio/frontend/jax_frontend.py 100.00% <100.00%> (ø)
kymatio/scattering1d/backend/jax_backend.py 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfbd1a3...eee8d2e. Read the comment docs.

@MuawizChaudhary
Copy link
Collaborator

@changhongw If you approve pls press the big green button!

@changhongw
Copy link
Collaborator

Thanks for noticing this problem!

@changhongw changhongw merged commit 1a87cee into kymatio:dev Jun 24, 2022
eickenberg pushed a commit that referenced this pull request Jul 5, 2022
…D dict (#900)

* include 'n' field in list output (1D, 2D)

fix #875

* remove singleton dim (-2) in out_type='dict'

fix #895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants