Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support command #482

Merged
merged 11 commits into from Nov 7, 2019

Conversation

@cfanoulis
Copy link
Contributor

cfanoulis commented Nov 7, 2019

I mean, it's what the title says.

Closes #458

Changelog?

Why, yes

Additions

  • feat: support command (4bf59bc)
  • chore: remove unneeded comment (98ab148)
  • fix: use language builder and adhere to form (d68d5aa)
  • fix: requested changes (4200e21)
  • feat: more aliases for support (bc7fb83)
  • fix: move language desc keys around (b98d301)
  • feat: "spanish" translation (95839a7)
  • refactor: apply suggestings from code review (4b0e249)
@cfanoulis cfanoulis requested a review from kyranet as a code owner Nov 7, 2019
src/commands/System/support.ts Outdated Show resolved Hide resolved
src/commands/System/support.ts Outdated Show resolved Hide resolved
src/languages/en-US.ts Outdated Show resolved Hide resolved
cfanoulis added 2 commits Nov 7, 2019
as requested by PyroTechniac
@cfanoulis cfanoulis requested review from PyroTechniac and kyranet Nov 7, 2019
src/languages/en-US.ts Outdated Show resolved Hide resolved
src/languages/en-US.ts Outdated Show resolved Hide resolved
src/languages/en-US.ts Outdated Show resolved Hide resolved
@cfanoulis

This comment has been minimized.

Copy link
Contributor Author

cfanoulis commented Nov 7, 2019

please do not merge yet.

@kyranet

This comment has been minimized.

Copy link
Owner

kyranet commented Nov 7, 2019

We won't while reviews are still not solved, @cfanoulis.

src/commands/System/support.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

Favna left a comment

We can do better on the text

src/languages/en-US.ts Outdated Show resolved Hide resolved
src/languages/en-US.ts Outdated Show resolved Hide resolved
cfanoulis and others added 5 commits Nov 7, 2019
Co-Authored-By: Gryffon Bellish <owenbellish@gmail.com>
Featuring my bad spanish, as well as Google Translate
@cfanoulis cfanoulis requested review from PyroTechniac, kyranet and Favna Nov 7, 2019
Copy link
Owner

kyranet left a comment

nits x10

src/languages/en-US.ts Outdated Show resolved Hide resolved
src/languages/en-US.ts Outdated Show resolved Hide resolved
src/languages/es-ES.ts Outdated Show resolved Hide resolved
src/languages/es-ES.ts Outdated Show resolved Hide resolved
src/languages/es-ES.ts Outdated Show resolved Hide resolved
src/languages/es-ES.ts Outdated Show resolved Hide resolved
src/lib/types/Languages.d.ts Outdated Show resolved Hide resolved
src/languages/en-US.ts Outdated Show resolved Hide resolved
src/languages/es-ES.ts Outdated Show resolved Hide resolved
src/languages/en-US.ts Outdated Show resolved Hide resolved
Co-Authored-By: Antonio Román <kyradiscord@gmail.com>
These categories are gonna be the death of me
@kyranet
kyranet approved these changes Nov 7, 2019
@kyranet kyranet merged commit 7cb0e03 into kyranet:master Nov 7, 2019
3 checks passed
3 checks passed
tsc
Details
eslint eslint
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
@cfanoulis cfanoulis deleted the cfanoulis:support-cmd branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.