Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove vscode settings file #32

Merged
merged 2 commits into from Dec 1, 2019

Conversation

@Favna
Copy link
Collaborator

Favna commented Dec 1, 2019

Line endings are covered in the editorconfig as per my last PR and it only causes issues when working around WSL / regular windows. Line endings should furthermore be handled in Git config, not VSCode.

See for example:

Favna added 2 commits Dec 1, 2019
Line endings are covered in the editorconfig as per my last PR and it
only causes issues when working around WSL / regular windows. Line
endings should furthermore be handled in Git config, not VSCode.

See for example:
- microsoft/vscode#67808
- https://help.github.com/en/github/using-git/configuring-git-to-handle-line-endings
@kyranet
kyranet approved these changes Dec 1, 2019
Copy link
Contributor

cfanoulis left a comment

why was pull request template removed I need to practice reading

@kyranet kyranet merged commit 3b56fdc into master Dec 1, 2019
7 checks passed
7 checks passed
eslint ESLint
Details
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
Redirect rules 1 redirect rule processed
Details
deploy/netlify Deploy preview ready!
Details
@kyranet kyranet deleted the meta-remove-vscode-file-line-endings branch Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.