Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hidden ip webshot #787

Merged
merged 3 commits into from Sep 6, 2018
Merged

hidden ip webshot #787

merged 3 commits into from Sep 6, 2018

Conversation

@valessiobrito
Copy link
Contributor

valessiobrito commented Jul 26, 2018

fix screenshot

Copy link
Member

hdiogenes left a comment

Approved. For the next screenshots, a tip: instead of putting a random IP address (which belongs to some random organization), there's a specific subnet reserved just to be used in examples and documentation – 192.0.2.0/24.

@beraldoleal

This comment has been minimized.

Copy link
Member

beraldoleal commented Jul 31, 2018

@valessiobrito please rebase this PR, is out-of-date.

@beraldoleal

This comment has been minimized.

Copy link
Member

beraldoleal commented Aug 30, 2018

@hdiogenes

This comment has been minimized.

Copy link
Member

hdiogenes commented Sep 3, 2018

I think the tests will be fixed after the next rebase, @valessiobrito.

@beraldoleal

This comment has been minimized.

Copy link
Member

beraldoleal commented Sep 3, 2018

@valessiobrito @hdiogenes come on guys... lets include this small PR! :/

@hdiogenes hdiogenes added this to the 2018.2b1 milestone Sep 6, 2018
@beraldoleal beraldoleal merged commit 2def0af into kytos:master Sep 6, 2018
1 check passed
1 check passed
Scrutinizer Analysis: No new issues – Tests: passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.