This repository was archived by the owner on Apr 22, 2024. It is now read-only.
Add unpack_message method to v0x04#320
Merged
Merged
Conversation
beraldoleal
suggested changes
Mar 21, 2017
| hdr_buff, msg_buff = buffer[:hdr_size], buffer[hdr_size:] | ||
| header = Header() | ||
| header.unpack(hdr_buff) | ||
| message = new_message_from_header(header) |
Member
Contributor
Author
There was a problem hiding this comment.
Actually, the v0x04 file defines new_message_from_header. @macartur and I have discussed about the methods being very similar to each other and the possibility to make a common file to all versions in the future, but right now this was the only missing method in this file in particular.
Member
There was a problem hiding this comment.
Yes, you are right. sorry, my fault, I was reading another file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #319