Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With peer discovery disabled, other servers can still add themselves #731

Closed
SomberNight opened this issue Feb 10, 2019 · 1 comment

Comments

@SomberNight
Copy link
Contributor

commented Feb 10, 2019

I haven't actually tested, but Selavi on IRC said that he has PEER_DISCOVERY=off set, and his server was reporting many peers regardless (including those not on the e-x default list).

I think the explanation is that other peers can still register themselves, even if you disable discovery.
Note that Selavi's server is on the e-x default list, so other peers WILL try to add themselves.

I think there should be a test for this in on_add_peer.

async def on_add_peer(self, features, source_info):

For example:

if self.env.peer_discovery != self.env.PD_ON:
    return False

@kyuupichan kyuupichan self-assigned this Feb 17, 2019

@kyuupichan kyuupichan added this to the 1.9.6 milestone Feb 17, 2019

@peleion

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

I can also confirm this using PEER_DISCOVERY=self. Additionally, the blacklist is not downloaded so phish servers show up as peers in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.