Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cancel context for proper shutdown in controllers #10415

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

eddycharly
Copy link
Member

@eddycharly eddycharly commented Jun 10, 2024

Explanation

Cancel context for proper shutdown in controllers.

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 657 lines in your changes missing coverage. Please review.

Project coverage is 10.03%. Comparing base (954245a) to head (877c339).

Files Patch % Lines
cmd/kyverno/main.go 0.00% 226 Missing ⚠️
cmd/cleanup-controller/main.go 0.00% 209 Missing ⚠️
cmd/reports-controller/main.go 0.00% 116 Missing ⚠️
cmd/background-controller/main.go 0.00% 106 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10415      +/-   ##
==========================================
- Coverage   10.03%   10.03%   -0.01%     
==========================================
  Files        1038     1038              
  Lines       93781    93785       +4     
==========================================
  Hits         9414     9414              
- Misses      83331    83335       +4     
  Partials     1036     1036              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eddycharly eddycharly changed the title fix: cancel context for proper shutdown in reports-controller fix: cancel context for proper shutdown in controllers Jun 10, 2024
@eddycharly eddycharly marked this pull request as ready for review June 10, 2024 07:30
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly enabled auto-merge (squash) June 10, 2024 08:01
auto-merge was automatically disabled June 10, 2024 08:52

Pull Request is not mergeable

@eddycharly eddycharly enabled auto-merge (squash) June 10, 2024 08:52
@eddycharly eddycharly merged commit a0932cf into kyverno:main Jun 10, 2024
250 of 252 checks passed
@realshuting
Copy link
Member

/cherry-pick release-1.12

@eddycharly eddycharly deleted the fix-reports-lease branch June 11, 2024 06:57
@eddycharly
Copy link
Member Author

/cherry-pick release-1.12

eddycharly added a commit to eddycharly/kyverno that referenced this pull request Jun 11, 2024
…o#10415)

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@realshuting realshuting added the cherry-pick-completed The PR was cherry-picked (or merged) to required release branches label Jun 11, 2024
@realshuting realshuting added this to the Kyverno Release 1.12.4 milestone Jun 11, 2024
realshuting pushed a commit that referenced this pull request Jun 11, 2024
#10426)

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
jslivka pushed a commit to jslivka/kyverno-hpa that referenced this pull request Jul 2, 2024
…o#10415)

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-completed The PR was cherry-picked (or merged) to required release branches cherry-pick-required milestone 1.12.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants