-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cancel context for proper shutdown in controllers #10415
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10415 +/- ##
==========================================
- Coverage 10.03% 10.03% -0.01%
==========================================
Files 1038 1038
Lines 93781 93785 +4
==========================================
Hits 9414 9414
- Misses 83331 83335 +4
Partials 1036 1036 ☔ View full report in Codecov by Sentry. |
e0d35ec
to
0ab9d95
Compare
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
a529107
to
17930de
Compare
MariamFahmy98
approved these changes
Jun 10, 2024
|
/cherry-pick release-1.12 |
|
/cherry-pick release-1.12 |
eddycharly
added a commit
to eddycharly/kyverno
that referenced
this pull request
Jun 11, 2024
…o#10415) Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
realshuting
pushed a commit
that referenced
this pull request
Jun 11, 2024
#10426) Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
jslivka
pushed a commit
to jslivka/kyverno-hpa
that referenced
this pull request
Jul 2, 2024
…o#10415) Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick-completed
The PR was cherry-picked (or merged) to required release branches
cherry-pick-required
milestone 1.12.4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Cancel context for proper shutdown in controllers.