Permalink
Browse files

skip interrupt tests on windows instead of TODO

(since they may sometimes pass)
buildbot.test.unit.test_slavecommand.Shell.testInterrupt1
buildbot.test.unit.test_slavecommand.Shell.testInterrupt2
  • Loading branch information...
1 parent 07dcb35 commit e6739cd298709e275562ac23c0d13482ecb7658b Dustin J. Mitchell committed Feb 3, 2010
Showing with 3 additions and 1 deletion.
  1. +3 −1 buildbot/test/unit/test_slavecommand.py
@@ -238,7 +238,7 @@ def _testInterrupt1_1(self, res):
if runtime.platformType == "posix":
self.failUnlessIn("process killed by signal", got)
if runtime.platformType != 'posix':
- testInterrupt1.todo = "interrupt doesn't appear to work under windows"
+ testInterrupt1.skip = "interrupt doesn't appear to work under windows"
# todo: twisted-specific command tests
@@ -286,6 +286,8 @@ def _testInterrupt2_2(self, res):
# N.B.: under windows, the trial process hangs out for another few
# seconds. I assume that the win32eventreactor is waiting for one of
# the lingering child processes to really finish.
+ if runtime.platformType != 'posix':
+ testInterrupt2.skip = "interrupt doesn't appear to work under windows"
haveProcess = interfaces.IReactorProcess(reactor, None)
if runtime.platformType == 'posix':

0 comments on commit e6739cd

Please sign in to comment.