Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideas, global review #92

Closed
klettier opened this issue Jul 30, 2019 · 4 comments
Closed

Ideas, global review #92

klettier opened this issue Jul 30, 2019 · 4 comments

Comments

@klettier
Copy link

klettier commented Jul 30, 2019

Here is a grouping of ideas for a better architecture

Global

  • Split console project into two projects -> lib + Console
    • Allow produce a separate nuget package for your lib
      • Allow people to use and extend your lib instead of using an executable
  • Use dependency injection everywhere
    • Allow behavior extension
    • Do not rely on static, e.g. Console.Error.WriteLine for log
    • Rely on interface and not on concrete class
      • Allow better testing
  • Migrate to new sdk csproj
  • Is targeting .net framework 4.0 still needed ?

GrouperPlan.cs

  • Split plan parsing from plan execution
    • ParseCommandLineArguments method could be static pure function
@l0ss
Copy link
Owner

l0ss commented Jul 30, 2019

Unfortunately targeting .NET 4.0 is necessary, to ensure it'll run on whatever wheezy shitbox the user happens to pop a shell on.

I don't have any particular objections to any of the other items above if you think they're worth implementing, but my focus in my (very) limited free time is on getting the dev branch working properly, then tuning existing features and implementing new ones.

@klettier
Copy link
Author

Ok, just tell me/list what is missing to be able to do the merge with master branch

@l0ss
Copy link
Owner

l0ss commented Jul 31, 2019

I've created a short list of issues with the 'dev' tag, Sh3r4's gonna create a more detailed list of issues based on her notes. Should provide plenty to work on.

@l0ss
Copy link
Owner

l0ss commented Nov 22, 2019

closed

@l0ss l0ss closed this as completed Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants