New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nitrogen doesn't correctly detect Desktop window when Conky with own_window used #88

Closed
daf opened this Issue Nov 22, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@daf
Member

daf commented Nov 22, 2016

From #86, @holmeslinux was using a Manjaro-JWM desktop that had a few conky windows defined. The conky windows have the own_window = true and own_window_type = 'desktop' settings set, which causes Nitrogen to assume they are some kind of full screen overlay similar to how older Nautilus worked. The fallback mechanism makes Nitrogen pick the X setter via UNKNOWN, which is screwing up Xinerama detection.

I've misinterpreted _NET_WM_WINDOW_TYPE=_NET_WM_WINDOW_TYPE_DESKTOP to mean only full-screen covering style windows which Nitrogen has to detect, not other uses of the property as conky does (correctly). Actual text:

_NET_WM_WINDOW_TYPE_DESKTOP indicates a desktop feature. This can include a single window containing desktop icons with the same dimensions as the screen, allowing the desktop environment to have full control of the desktop, without the need for proxying root window clicks.

Note can.

Will have to refactor the detection mechanism to take WM_CLASS targets that we're actively searching for so we can filter any _NET_WM_WINDOW_TYPE_DESKTOP discoveries and continue searching for more of them.

@daf daf added this to the 1.6.x milestone Nov 22, 2016

@daf daf self-assigned this Nov 22, 2016

@daf

This comment has been minimized.

Member

daf commented Nov 23, 2016

@daf daf closed this in 9821adf Dec 3, 2016

@daf daf referenced this issue Jan 1, 2017

Closed

conflict with conky #90

@daf daf modified the milestones: 1.6.x, 1.6.1 Jan 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment