Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we still need /lw prefix? What does it cost to remove it? #145

Open
astappiev opened this issue Apr 4, 2020 · 6 comments
Open

Do we still need /lw prefix? What does it cost to remove it? #145

astappiev opened this issue Apr 4, 2020 · 6 comments
Labels
low priority You should work on it only in case if no other issues
Milestone

Comments

@astappiev
Copy link
Member

Reasons to remove it:

  • Better links autocomplete. An IDE doesn't know about base tag.
  • Shorter links
@astappiev
Copy link
Member Author

In GitLab by @PhilippKemkes on Apr 4, 2020, 14:24

I plan to use 2 letter language codes, at least on public pages, instead of lw, to make Google aware of our translations. Then the existing prefix and base path are useful. But it has been in a separate branch for a while and I didn't test it in detail. I do not plan to finish it before V3 is published.

What are other problems besides the IDE?

@astappiev
Copy link
Member Author

Google is only indexing a few pages.

We can leave English unprefixed.

What are other problems besides the IDE?

Can't specify, removed.

@astappiev
Copy link
Member Author

In GitLab by @PhilippKemkes on Apr 4, 2020, 18:00

If you are very keen to remove it then go ahead. We can also use filename.de.jsf or something like that on the public pages.

But we will still need a redirect from /lw/* to /* to keep all old links working.

@astappiev
Copy link
Member Author

In GitLab by @PhilippKemkes on Apr 5, 2020, 10:55

But if it shall be done. Then it should be done before we do the final test round of version3. The rewrite rule should not yet be activated so that we can recognize wrong links.

@astappiev
Copy link
Member Author

One more benefit of having /lw prefix is that we have all pages in a subfolder of WebContent.

@astappiev
Copy link
Member Author

In GitLab by @PhilippKemkes on Apr 20, 2020, 15:30

removed milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority You should work on it only in case if no other issues
Projects
None yet
Development

No branches or pull requests

1 participant