Skip to content

Commit

Permalink
Fix overly-prescriptive p2p-segwit test for new fetch logic
Browse files Browse the repository at this point in the history
Github-Pull: bitcoin#8393
Rebased-From: be7555f
  • Loading branch information
TheBlueMatt authored and laanwj committed Oct 13, 2016
1 parent fe1975a commit 890ac25
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions qa/rpc-tests/p2p-segwit.py
Expand Up @@ -909,14 +909,6 @@ def test_witness_tx_relay_before_segwit_activation(self):
# But eliminating the witness should fix it
self.test_node.test_transaction_acceptance(tx, with_witness=False, accepted=True)

# Verify that inv's to test_node come with getdata's for non-witness tx's
# Just tweak the transaction, announce it, and verify we get a getdata
# for a normal tx
tx.vout[0].scriptPubKey = CScript([OP_TRUE, OP_TRUE])
tx.rehash()
self.test_node.announce_tx_and_wait_for_getdata(tx)
assert(self.test_node.last_getdata.inv[0].type == 1)

# Cleanup: mine the first transaction and update utxo
self.nodes[0].generate(1)
assert_equal(len(self.nodes[0].getrawmempool()), 0)
Expand Down Expand Up @@ -1022,7 +1014,7 @@ def test_tx_relay_after_segwit_activation(self):
def test_block_relay(self, segwit_activated):
print("\tTesting block relay")

blocktype = 2|MSG_WITNESS_FLAG if segwit_activated else 2
blocktype = 2|MSG_WITNESS_FLAG

# test_node has set NODE_WITNESS, so all getdata requests should be for
# witness blocks.
Expand Down

0 comments on commit 890ac25

Please sign in to comment.