New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/product types #32

Merged
merged 8 commits into from Oct 10, 2018

Conversation

Projects
None yet
2 participants
@tleguijt
Contributor

tleguijt commented Oct 9, 2018

No description provided.

@tleguijt tleguijt requested a review from MichielBijland Oct 9, 2018

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 9, 2018

Codecov Report

Merging #32 into master will decrease coverage by 5.37%.
The diff coverage is 20.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   37.18%   31.81%   -5.38%     
==========================================
  Files           7        8       +1     
  Lines        1167     1650     +483     
==========================================
+ Hits          434      525      +91     
- Misses        726     1115     +389     
- Partials        7       10       +3
Impacted Files Coverage Δ
commercetools/provider.go 75% <100%> (+0.31%) ⬆️
commercetools/resource_product_type.go 18.67% <18.67%> (ø)
commercetools/utils.go 12.24% <46.15%> (+12.24%) ⬆️
commercetools/resource_type.go 27.06% <50%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df98fe9...df45782. Read the comment docs.

codecov bot commented Oct 9, 2018

Codecov Report

Merging #32 into master will decrease coverage by 5.37%.
The diff coverage is 20.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   37.18%   31.81%   -5.38%     
==========================================
  Files           7        8       +1     
  Lines        1167     1650     +483     
==========================================
+ Hits          434      525      +91     
- Misses        726     1115     +389     
- Partials        7       10       +3
Impacted Files Coverage Δ
commercetools/provider.go 75% <100%> (+0.31%) ⬆️
commercetools/resource_product_type.go 18.67% <18.67%> (ø)
commercetools/utils.go 12.24% <46.15%> (+12.24%) ⬆️
commercetools/resource_type.go 27.06% <50%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df98fe9...df45782. Read the comment docs.

@MichielBijland MichielBijland assigned jberghoef and unassigned jberghoef Oct 9, 2018

@MichielBijland MichielBijland requested a review from jberghoef Oct 9, 2018

@tleguijt tleguijt merged commit d77588d into master Oct 10, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tleguijt tleguijt deleted the feature/product_types branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment