forked from tadzik/panda
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Fix up stuff for GLR
- Loading branch information
Showing
4 changed files
with
5 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run-and-gather-output returns a list of Pairs now that you List-assign to a list of Pairs.
Previously it didn't matter in which order run-and-gather-output returned the pairs, because we bound a Capture to the list of Pairs and it did the right thing. We lost this nice ability. I'd say we should not pretend that it still works that way and use a simple list assignment instead:
my ($output, $stdout, $stderr, $passed) = run-and-gather-output(...);
and a plain return $output, $stdtout, $stderr, $passed in run-and-gather-output.
That way it's clear that no magic is happening and we don't need the .value in line 33.