Skip to content

Conversation

@jluebbe
Copy link
Member

@jluebbe jluebbe commented Nov 17, 2017

No description provided.

@jluebbe jluebbe self-assigned this Nov 17, 2017
@jluebbe jluebbe requested a review from Emantor November 17, 2017 11:16
@codecov-io
Copy link

codecov-io commented Nov 17, 2017

Codecov Report

Merging #155 into master will decrease coverage by <.1%.
The diff coverage is 48.4%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #155     +/-   ##
========================================
- Coverage    52.4%   52.4%   -0.1%     
========================================
  Files          84      84             
  Lines        4430    4460     +30     
========================================
+ Hits         2325    2338     +13     
- Misses       2105    2122     +17
Impacted Files Coverage Δ
labgrid/factory.py 98.6% <100%> (+0.2%) ⬆️
labgrid/remote/client.py 48.3% <19%> (-1.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c08d6...6198632. Read the comment docs.

Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
[r.czerwinski@pengutronix.de: Renamed duplicated test name]
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed up a duplicated test name. Otherwise looks good to me.

@Emantor Emantor merged commit 4ec8fe6 into labgrid-project:master Nov 19, 2017
Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old Tab state...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants