ser2net fix #245
Merged
ser2net fix #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
=======================================
- Coverage 55.1% 55% -0.2%
=======================================
Files 105 105
Lines 6217 6243 +26
=======================================
+ Hits 3431 3437 +6
- Misses 2786 2806 +20
Continue to review full report at Codecov.
|
|
Do we have any idea why the underlying disconnects are not recognised? This workaround looks fine, but it would be better if we could fix the underlying issue as well. |
Emantor
approved these changes
May 23, 2018
|
The exporter misses the intermediate states because it doesn't process the the udev events (which is done in resource/udev.py) and can only see the current state. |
|
The first commit also fixes #236. |
|
Thanks for noticing 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When many udev events happen very quickly (such as when a whole USB bus is reconnected), the intermediate disconnected state may be missed. This patch makes sure to restart ser2net when needed by comparing the current parameters to the ones used to start running ser2net process.