fix ResourceManager and limit default place creation #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
Emantor
reviewed
Feb 27, 2017
labgrid/resource/common.py
Outdated
| return instance | ||
|
|
||
| def __attrs_post_init__(self): | ||
| print("new {}".format(self)) |
Member
There was a problem hiding this comment.
Is this a needed functionality print or just a leftover debug print?
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Emantor
pushed a commit
that referenced
this pull request
Aug 7, 2023
The docker docs contain [1] these COPY forms: COPY [--chown=<user>:<group>] [--chmod=<perms>] <src>... <dest> COPY [--chown=<user>:<group>] [--chmod=<perms>] ["<src>",... "<dest>"] Arguments within [ ] are optional. The square brackets are not meant to be part of the actual instruction. The docker docs [1] mention that "[e]ach <src> may contain wildcards and matching will be done using Go’s filepath.Match rules". Go’s filepath.Match [2] interprets terms in square brackets as a character class. "[--chown=root:root]" must have been interpreted as a valid character class until recently. A couple of days ago, building the "dut" service started failing: Building dut #0 building with "default" instance using docker driver #1 [internal] load build definition from Dockerfile #1 transferring dockerfile: 924B done #1 DONE 0.0s #2 [internal] load .dockerignore #2 transferring context: 2B done #2 DONE 0.0s #3 [internal] load metadata for docker.io/library/debian:bookworm-slim #3 DONE 0.1s #4 [1/4] FROM docker.io/library/debian:bookworm-slim@sha256:89468107e4c2b9fdea2f15fc582bf92c25aa4296a661ca0202f7ea2f4fc3f48c #4 CACHED #5 [internal] load build context #5 transferring context: 56B done #5 ERROR: error from sender: invalid includepatterns: []: syntax error in pattern Fix this by dropping the accidental square brackets around the --chown option. [1] https://docs.docker.com/engine/reference/builder/#copy [2] https://pkg.go.dev/path/filepath#Match Signed-off-by: Bastian Krause <bst@pengutronix.de>
Bastian-Krause
added a commit
that referenced
this pull request
Aug 8, 2023
The docker docs contain [1] these COPY forms: COPY [--chown=<user>:<group>] [--chmod=<perms>] <src>... <dest> COPY [--chown=<user>:<group>] [--chmod=<perms>] ["<src>",... "<dest>"] Arguments within [ ] are optional. The square brackets are not meant to be part of the actual instruction. The docker docs [1] mention that "[e]ach <src> may contain wildcards and matching will be done using Go’s filepath.Match rules". Go’s filepath.Match [2] interprets terms in square brackets as a character class. "[--chown=root:root]" must have been interpreted as a valid character class until recently. A couple of days ago, building the "dut" service started failing: Building dut #0 building with "default" instance using docker driver #1 [internal] load build definition from Dockerfile #1 transferring dockerfile: 924B done #1 DONE 0.0s #2 [internal] load .dockerignore #2 transferring context: 2B done #2 DONE 0.0s #3 [internal] load metadata for docker.io/library/debian:bookworm-slim #3 DONE 0.1s #4 [1/4] FROM docker.io/library/debian:bookworm-slim@sha256:89468107e4c2b9fdea2f15fc582bf92c25aa4296a661ca0202f7ea2f4fc3f48c #4 CACHED #5 [internal] load build context #5 transferring context: 56B done #5 ERROR: error from sender: invalid includepatterns: []: syntax error in pattern Fix this by dropping the accidental square brackets around the --chown option. [1] https://docs.docker.com/engine/reference/builder/#copy [2] https://pkg.go.dev/path/filepath#Match Signed-off-by: Bastian Krause <bst@pengutronix.de>
userid0x0
pushed a commit
to userid0x0/labgrid
that referenced
this pull request
Sep 8, 2023
The docker docs contain [1] these COPY forms: COPY [--chown=<user>:<group>] [--chmod=<perms>] <src>... <dest> COPY [--chown=<user>:<group>] [--chmod=<perms>] ["<src>",... "<dest>"] Arguments within [ ] are optional. The square brackets are not meant to be part of the actual instruction. The docker docs [1] mention that "[e]ach <src> may contain wildcards and matching will be done using Go’s filepath.Match rules". Go’s filepath.Match [2] interprets terms in square brackets as a character class. "[--chown=root:root]" must have been interpreted as a valid character class until recently. A couple of days ago, building the "dut" service started failing: Building dut #0 building with "default" instance using docker driver labgrid-project#1 [internal] load build definition from Dockerfile labgrid-project#1 transferring dockerfile: 924B done labgrid-project#1 DONE 0.0s labgrid-project#2 [internal] load .dockerignore labgrid-project#2 transferring context: 2B done labgrid-project#2 DONE 0.0s labgrid-project#3 [internal] load metadata for docker.io/library/debian:bookworm-slim labgrid-project#3 DONE 0.1s labgrid-project#4 [1/4] FROM docker.io/library/debian:bookworm-slim@sha256:89468107e4c2b9fdea2f15fc582bf92c25aa4296a661ca0202f7ea2f4fc3f48c labgrid-project#4 CACHED labgrid-project#5 [internal] load build context labgrid-project#5 transferring context: 56B done labgrid-project#5 ERROR: error from sender: invalid includepatterns: []: syntax error in pattern Fix this by dropping the accidental square brackets around the --chown option. [1] https://docs.docker.com/engine/reference/builder/#copy [2] https://pkg.go.dev/path/filepath#Match Signed-off-by: Bastian Krause <bst@pengutronix.de>
rpoisel
pushed a commit
to honeytreelabs/labgrid
that referenced
this pull request
Oct 24, 2023
The docker docs contain [1] these COPY forms: COPY [--chown=<user>:<group>] [--chmod=<perms>] <src>... <dest> COPY [--chown=<user>:<group>] [--chmod=<perms>] ["<src>",... "<dest>"] Arguments within [ ] are optional. The square brackets are not meant to be part of the actual instruction. The docker docs [1] mention that "[e]ach <src> may contain wildcards and matching will be done using Go’s filepath.Match rules". Go’s filepath.Match [2] interprets terms in square brackets as a character class. "[--chown=root:root]" must have been interpreted as a valid character class until recently. A couple of days ago, building the "dut" service started failing: Building dut #0 building with "default" instance using docker driver labgrid-project#1 [internal] load build definition from Dockerfile labgrid-project#1 transferring dockerfile: 924B done labgrid-project#1 DONE 0.0s labgrid-project#2 [internal] load .dockerignore labgrid-project#2 transferring context: 2B done labgrid-project#2 DONE 0.0s labgrid-project#3 [internal] load metadata for docker.io/library/debian:bookworm-slim labgrid-project#3 DONE 0.1s labgrid-project#4 [1/4] FROM docker.io/library/debian:bookworm-slim@sha256:89468107e4c2b9fdea2f15fc582bf92c25aa4296a661ca0202f7ea2f4fc3f48c labgrid-project#4 CACHED labgrid-project#5 [internal] load build context labgrid-project#5 transferring context: 56B done labgrid-project#5 ERROR: error from sender: invalid includepatterns: []: syntax error in pattern Fix this by dropping the accidental square brackets around the --chown option. [1] https://docs.docker.com/engine/reference/builder/#copy [2] https://pkg.go.dev/path/filepath#Match Signed-off-by: Bastian Krause <bst@pengutronix.de>
legraps
pushed a commit
to BasicServicePeople/labgrid
that referenced
this pull request
Nov 6, 2023
The docker docs contain [1] these COPY forms: COPY [--chown=<user>:<group>] [--chmod=<perms>] <src>... <dest> COPY [--chown=<user>:<group>] [--chmod=<perms>] ["<src>",... "<dest>"] Arguments within [ ] are optional. The square brackets are not meant to be part of the actual instruction. The docker docs [1] mention that "[e]ach <src> may contain wildcards and matching will be done using Go’s filepath.Match rules". Go’s filepath.Match [2] interprets terms in square brackets as a character class. "[--chown=root:root]" must have been interpreted as a valid character class until recently. A couple of days ago, building the "dut" service started failing: Building dut #0 building with "default" instance using docker driver #1 [internal] load build definition from Dockerfile #1 transferring dockerfile: 924B done #1 DONE 0.0s labgrid-project#2 [internal] load .dockerignore labgrid-project#2 transferring context: 2B done labgrid-project#2 DONE 0.0s labgrid-project#3 [internal] load metadata for docker.io/library/debian:bookworm-slim labgrid-project#3 DONE 0.1s labgrid-project#4 [1/4] FROM docker.io/library/debian:bookworm-slim@sha256:89468107e4c2b9fdea2f15fc582bf92c25aa4296a661ca0202f7ea2f4fc3f48c labgrid-project#4 CACHED labgrid-project#5 [internal] load build context labgrid-project#5 transferring context: 56B done labgrid-project#5 ERROR: error from sender: invalid includepatterns: []: syntax error in pattern Fix this by dropping the accidental square brackets around the --chown option. [1] https://docs.docker.com/engine/reference/builder/#copy [2] https://pkg.go.dev/path/filepath#Match Signed-off-by: Bastian Krause <bst@pengutronix.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.