Skip to content

Conversation

@Emantor
Copy link
Member

@Emantor Emantor commented Mar 21, 2017

No description provided.

@Emantor Emantor requested a review from jluebbe March 21, 2017 07:15
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 47.925% when pulling 2d7ba5e on Emantor:topic/docs2 into 4e1832b on labgrid-project:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 47.925% when pulling d89528c on Emantor:topic/docs2 into 4e1832b on labgrid-project:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 47.925% when pulling d89528c on Emantor:topic/docs2 into 4e1832b on labgrid-project:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 47.925% when pulling b78612b on Emantor:topic/docs2 into 4e1832b on labgrid-project:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 48.084% when pulling b85a363 on Emantor:topic/docs2 into 4e1832b on labgrid-project:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 47.925% when pulling b85a363 on Emantor:topic/docs2 into 4e1832b on labgrid-project:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 47.925% when pulling 59bb2ee on Emantor:topic/docs2 into 4e1832b on labgrid-project:master.

@Emantor Emantor added this to the labgrid 0.1 milestone Mar 21, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 47.855% when pulling f556147 on Emantor:topic/docs2 into 4e1832b on labgrid-project:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 47.855% when pulling 7f765e5 on Emantor:topic/docs2 into 4e1832b on labgrid-project:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 47.855% when pulling 6c8306e on Emantor:topic/docs2 into be2225d on labgrid-project:master.

@Emantor Emantor force-pushed the topic/docs2 branch 4 times, most recently from 83a0498 to 71deefd Compare March 21, 2017 14:27
@coveralls
Copy link

Coverage Status

Coverage remained the same at 47.704% when pulling 83a0498 on Emantor:topic/docs2 into 694b3a4 on labgrid-project:master.

@Emantor Emantor changed the title [WIP] Topic/docs2 [RDY] Topic/docs2 Mar 21, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 47.704% when pulling 71deefd on Emantor:topic/docs2 into 694b3a4 on labgrid-project:master.

Copy link
Member

@jluebbe jluebbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also squash some documentation commits for the same files.


.. code-block:: bash
$ sudo apt install libow-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should document this requirement somewhere else.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now documented in the usage/installation/extras requires section.

CommandProtocol
------------
---------------
.. autoclass:: labgrid.protocol.CommandProtocol
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CommandProtocol is not a driver.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started to group the Drivers by Protocol, but since we can just list their base classes I will remove that.

doc/usage.rst Outdated
Installation
------------

The default installation is available via Pypi:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PyPI instead of Pypi.

Labgrid supports different extras:

- onewire: install onewire support, requires onewire from pypi >=0.0.2
- coordinator: installs required depencies to start a crossbar coordinator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an example how to enable both extras.

Emantor added 5 commits March 21, 2017 18:36
Also add autoclasses for some Drivers.

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Napoleon enables the automatic conversion from google style docstrings to rst
sphinx docstrings. Also fix the mocks to allow apidoc to parse the authenticator
and remove the static html path for now.

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Emantor added 2 commits March 21, 2017 18:36
Add a new installation section which documents how to use the extras.

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
@Emantor
Copy link
Member Author

Emantor commented Mar 21, 2017

Squashed it some more, fixed the suggestions.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 47.862% when pulling 30609ab on Emantor:topic/docs2 into 694b3a4 on labgrid-project:master.

Emantor added 4 commits March 22, 2017 09:19
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 47.862% when pulling 82aea0b on Emantor:topic/docs2 into 694b3a4 on labgrid-project:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 47.704% when pulling 82aea0b on Emantor:topic/docs2 into 694b3a4 on labgrid-project:master.

@jluebbe jluebbe merged commit e63bd00 into labgrid-project:master Mar 22, 2017
@jluebbe jluebbe changed the title [RDY] Topic/docs2 add more documentation Mar 22, 2017
@Emantor Emantor deleted the topic/docs2 branch March 22, 2017 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants