Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the Debian package build on non-x86 platforms #429

Merged
merged 2 commits into from May 15, 2019

Conversation

Projects
None yet
2 participants
@bgermann
Copy link

commented May 15, 2019

Add the missing development packages for binary Python extensions that Labgrid depends on.
This is needed for non-x86 platforms to build as there are no platform packages available for them on PyPI. I tested it on armhf with buster and stretch.

The binary exclusion that was added yesterday is now only applied for two packages that make the build fail otherwise. With :all: the build fails as well because there are source dist issues with at least one dependency.

Checklist

  • PR has been tested
@codecov

This comment has been minimized.

Copy link

commented May 15, 2019

Codecov Report

Merging #429 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #429   +/-   ##
======================================
  Coverage    58.1%   58.1%           
======================================
  Files         114     114           
  Lines        7108    7108           
======================================
  Hits         4132    4132           
  Misses       2976    2976

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0674616...1030283. Read the comment docs.

@jluebbe jluebbe self-assigned this May 15, 2019

Bastian Germann added some commits May 14, 2019

debian: add build dependencies for Python extensions
There are no platform wheels available on Python for non-x86 platforms.
Add the minimum missing dependencies to build the Python packages' extensions.

Signed-off-by: Bastian Germann <bage@linutronix.de>
debian: exclude only cffi and numpy binaries
The package will not build with all wheels disabled because e.g. the hpack
source dist has an encoding bug in its setup.py. It reads HISTORY.rst as
ascii while it has a non-ascii character.

Signed-off-by: Bastian Germann <bage@linutronix.de>

@jluebbe jluebbe force-pushed the bgermann:debian-nonx86 branch from 56e4332 to 1030283 May 15, 2019

@jluebbe
Copy link
Member

left a comment

I had hoped to have less random python binary problems by rebuilding all packages at the cost of some build time, but that seems to be futile...
So I'm fine with manually managing the list of excluded packages for now.
I've also changed the commit subjects to fit our conventions.

@jluebbe jluebbe merged commit 2d12dd7 into labgrid-project:master May 15, 2019

4 checks passed

DCO DCO
Details
codecov/patch Coverage not affected when comparing 0674616...1030283
Details
codecov/project 58.1% remains the same compared to 0674616
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bgermann bgermann deleted the bgermann:debian-nonx86 branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.