Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytestplugin/fixtures: use request.config #467

Merged

Conversation

Projects
None yet
2 participants
@Emantor
Copy link
Member

commented Jul 8, 2019

Description
The global pytest.config has been deprecated, use the suggested
request.config instead.

Fixes #466

pytestplugin/fixtures: use request.config
The global pytest.config has been deprecated, use the suggested
request.config instead.

Fixes #466

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>

@Emantor Emantor added the fix label Jul 8, 2019

@Emantor Emantor added this to the v0.3.0 milestone Jul 8, 2019

@Emantor Emantor requested a review from jluebbe Jul 8, 2019

@Emantor Emantor self-assigned this Jul 8, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 8, 2019

Codecov Report

Merging #467 into master will decrease coverage by <.1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #467     +/-   ##
========================================
- Coverage    56.5%   56.5%   -0.1%     
========================================
  Files         118     118             
  Lines        7374    7374             
========================================
- Hits         4169    4168      -1     
- Misses       3205    3206      +1
Impacted Files Coverage Δ
labgrid/pytestplugin/fixtures.py 65.5% <100%> (ø) ⬆️
labgrid/util/agentwrapper.py 96.5% <0%> (-1.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1663f52...5ea94a2. Read the comment docs.

@jluebbe jluebbe merged commit 6ea45bb into labgrid-project:master Jul 10, 2019

4 checks passed

DCO DCO
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 56.5%)
Details
codecov/project Absolute coverage decreased by -<.1% but relative coverage increased by +43.4% compared to 1663f52
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.