Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

place reservation #483

Merged
merged 8 commits into from Sep 18, 2019

Conversation

@jluebbe
Copy link
Member

commented Aug 2, 2019

Description
When using labgrid with Jenkins, it can happen that a place is already used by someone/something else. In that case, it would be useful to let the test job wait until a compatible place is available.

This PR implements an initial version of place reservation using tags and filters, and a scheduler which allocates places. Documentation is still missing and more tests are needed.

This builds on PR #481.

Checklist

  • Documentation for the feature
  • Tests for the feature
  • The arguments and description in doc/configuration.rst have been updated
  • Add a section on how to use the feature to doc/usage.rst
  • CHANGES.rst has been updated
  • PR has been tested
  • Man pages have been regenerated
@jluebbe jluebbe added the enhancement label Aug 2, 2019
@jluebbe jluebbe requested a review from Emantor Aug 2, 2019
@jluebbe jluebbe self-assigned this Aug 2, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 2, 2019

Codecov Report

Merging #483 into master will decrease coverage by 0.3%.
The diff coverage is 44%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #483     +/-   ##
========================================
- Coverage    57.2%   56.8%   -0.4%     
========================================
  Files         122     123      +1     
  Lines        7870    8215    +345     
========================================
+ Hits         4506    4672    +166     
- Misses       3364    3543    +179
Impacted Files Coverage Δ
labgrid/remote/coordinator.py 0% <0%> (ø) ⬆️
labgrid/remote/scheduler.py 100% <100%> (ø)
labgrid/remote/client.py 44% <70.9%> (+3.2%) ⬆️
labgrid/remote/common.py 84.6% <89.4%> (+7.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c51b1...7ab849e. Read the comment docs.

@jluebbe jluebbe force-pushed the jluebbe:place-reservation branch from ba67f0b to 336af2b Aug 6, 2019
@jluebbe jluebbe marked this pull request as ready for review Aug 6, 2019
@jluebbe jluebbe force-pushed the jluebbe:place-reservation branch from 336af2b to f8280fe Aug 13, 2019
labgrid/remote/coordinator.py Outdated Show resolved Hide resolved
labgrid/remote/scheduler.py Outdated Show resolved Hide resolved
labgrid/remote/scheduler.py Outdated Show resolved Hide resolved
labgrid/remote/scheduler.py Outdated Show resolved Hide resolved
@Emantor Emantor added the breaking label Aug 16, 2019
@jluebbe jluebbe force-pushed the jluebbe:place-reservation branch from f8280fe to 8416a34 Sep 9, 2019
@jluebbe jluebbe requested a review from Emantor Sep 9, 2019
jluebbe added 8 commits Aug 1, 2019
This is needed for reservations and filters later.

Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
This avoids the need to use the wait command if one wants to wait for
the reservation immediately.

Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
@jluebbe jluebbe force-pushed the jluebbe:place-reservation branch from 8416a34 to 7ab849e Sep 10, 2019
@jluebbe jluebbe merged commit de089a7 into labgrid-project:master Sep 18, 2019
2 of 4 checks passed
2 of 4 checks passed
codecov/patch 44% of diff hit (target 57.2%)
Details
codecov/project 56.8% (-0.4%) compared to a9c51b1
Details
DCO DCO
Details
Travis CI - Pull Request Build Passed
Details
@jluebbe jluebbe deleted the jluebbe:place-reservation branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.