Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various smaller fixes and cleanups #564

Merged
merged 3 commits into from Feb 11, 2020
Merged

Conversation

@Emantor
Copy link
Member

Emantor commented Jan 27, 2020

Description
Add some crossbar documentation, fix SSH timeout handling and remove hawkbit and usbstick.

Checklist

  • PR has been tested
@Emantor Emantor requested a review from jluebbe Jan 27, 2020
@Emantor Emantor self-assigned this Jan 27, 2020
@Emantor Emantor force-pushed the Emantor:fix/various branch from fab4361 to cda2868 Jan 27, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 27, 2020

Codecov Report

Merging #564 into master will increase coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #564     +/-   ##
========================================
+ Coverage    58.3%   58.5%   +0.1%     
========================================
  Files         127     124      -3     
  Lines        8842    8689    -153     
========================================
- Hits         5161    5089     -72     
+ Misses       3681    3600     -81
Impacted Files Coverage Δ
labgrid/driver/sshdriver.py 44.7% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6c6e3f...ca51017. Read the comment docs.

CHANGES.rst Outdated Show resolved Hide resolved
@Emantor Emantor force-pushed the Emantor:fix/various branch from cda2868 to f8f4a3c Feb 3, 2020
Copy link
Contributor

Bastian-Krause left a comment

Please also pass the timeout from run() to _run(). Also remove the # pylint: disable=unused-argument from run() and _run(), it does not apply anymore.

Is there a reason to set the default timeout to None? If not, please use timeout=30 as default just like the other (high-level) drivers. I'd like to introduce this as the default timeout in the CommandProtocol in a future PR.

@Emantor

This comment has been minimized.

Copy link
Member Author

Emantor commented Feb 7, 2020

I would not introduce this in this PR, since you have sent one which does the mentioned change. Are you otherwise fine with this PR @Bastian-Krause?

@Bastian-Krause

This comment has been minimized.

Copy link
Contributor

Bastian-Krause commented Feb 7, 2020

Oh right, I did that in #574. That means I can replace
def _run(self, command: str, *, timeout: int = None):
with
def _run(self, command: str, *, timeout: int = 30):
in that PR, right?

@Emantor

This comment has been minimized.

Copy link
Member Author

Emantor commented Feb 7, 2020

Yes.

Oh right, I did that in #574. That means I can replace
def _run(self, command: str, *, timeout: int = None):
with
def _run(self, command: str, *, timeout: int = 30):
in that PR, right?

Yes.

@Bastian-Krause

This comment has been minimized.

Copy link
Contributor

Bastian-Krause commented Feb 7, 2020

Done.

Emantor added 3 commits Dec 6, 2019
Respect the passed timeout when commands are run.

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Mention that the crossbar config is meant for development and should be
customized in production environments.

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
These are currently neither used nor tested and should rather be
integrated into labgridhelper. Remove them from the labgrid repository.

Fixes #430

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
@jluebbe jluebbe force-pushed the Emantor:fix/various branch from f8f4a3c to ca51017 Feb 10, 2020
@jluebbe jluebbe merged commit 49be4eb into labgrid-project:master Feb 11, 2020
3 of 4 checks passed
3 of 4 checks passed
codecov/patch 0% of diff hit (target 58.3%)
Details
DCO DCO
Details
Travis CI - Pull Request Build Passed
Details
codecov/project 58.5% (+0.1%) compared to a6c6e3f
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.