Skip to content

fix: do not auto logout when preserve login true #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2023
Merged

fix: do not auto logout when preserve login true #1752

merged 1 commit into from
Jul 3, 2023

Conversation

@chisacam
Copy link
Contributor

@chisacam chisacam commented Jun 26, 2023

@cla-assistant
Copy link

cla-assistant bot commented Jun 26, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the size:S 10~30 LoC label Jun 26, 2023
inureyes
inureyes reviewed Jul 3, 2023
View reviewed changes
Copy link
Member

@inureyes inureyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inureyes inureyes added effort:easy Need to understand only a specific region of codes (good first issue, easy). urgency:1 If no other duties are available, volunteer to help. impact:invisible This change is invisible to users (internal changes). field:UI / UX labels Jul 3, 2023
@inureyes inureyes added this to the 22.09 milestone Jul 3, 2023
@inureyes inureyes merged commit 136d111 into lablup:main Jul 3, 2023
@chisacam chisacam deleted the bugfix/do_not_logout_when_preserve_login_true branch August 3, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inureyes inureyes inureyes left review comments

Assignees

@chisacam chisacam

Labels

effort:easy Need to understand only a specific region of codes (good first issue, easy). field:UI / UX impact:invisible This change is invisible to users (internal changes). size:S 10~30 LoC urgency:1 If no other duties are available, volunteer to help.

Projects

None yet

Milestone

22.09

Development

Successfully merging this pull request may close these issues.

"Keep Login Session Information while Logout" option not working on electron app

2 participants

@chisacam @inureyes