Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove graphene field's deprecation/description setter function #1734

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Nov 23, 2023

follow-up #1677

Write graphene field's deprecation/description message string directly instead of using message generation functions.
This is suggested by @achimnol, as writing the message directly would be better for readability

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@fregataa fregataa added this to the 23.09 milestone Nov 23, 2023
@fregataa fregataa self-assigned this Nov 23, 2023
@github-actions github-actions bot added comp:manager Related to Manager component size:L 100~500 LoC labels Nov 23, 2023
@fregataa fregataa added this pull request to the merge queue Feb 15, 2024
Merged via the queue into main with commit bbcee9a Feb 15, 2024
27 checks passed
@fregataa fregataa deleted the fix/set-deprecation-msg-for-each branch February 15, 2024 05:18
fregataa added a commit that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants