Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Introduce isort #495

Merged
merged 5 commits into from
Jun 27, 2022
Merged

ci: Introduce isort #495

merged 5 commits into from
Jun 27, 2022

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Jun 27, 2022

As the number of code contributors grows, let's introduce automated import sorting.

After merging this PR, please merge the main branch to your PR branches.
There will be conflicts and resolve them by git checkout --ours . to ignore conflicts and preserve the PR's changes.
After merge, just run ./pants fmt :: to auto-fix all your PR's local changes that are not conformant to the isort's policy.

Resolved #482.

@achimnol achimnol added this to the 22.03 milestone Jun 27, 2022
@achimnol achimnol added the area:infrastructure Infrastructure-related issues label Jun 27, 2022
@achimnol achimnol self-assigned this Jun 27, 2022
@achimnol achimnol merged commit 39c292e into main Jun 27, 2022
@achimnol achimnol deleted the ci/introduce-isort branch June 27, 2022 04:26
achimnol added a commit that referenced this pull request Jun 27, 2022
* setup: Add isort configuration
* setup: Update isort configs
* docs: Add guide for running auto formatters
* style: Apply isort to all source and test files

Backported-From: main (22.06)
Backported-To: 22.03
@Yaminyam Yaminyam added the size:XL 500~ LoC label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:infrastructure Infrastructure-related issues size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce isort as our formatter and linter
2 participants