This repository has been archived by the owner on Sep 20, 2019. It is now read-only.
Development #13
Merged
Development #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mobile into Michael-Gunter I need fix.
added navigation between views and side drawer functionality
…tracted, HeaderTitle extracted, tested with ios and android in both devices and simulator for android
Michael gunter
Evening merge with people search and navigation
…into ryan-walker i want the latest branch
…mobile into ryan-walker i want development
NightlyD3V
approved these changes
Jun 14, 2019
There was a problem hiding this comment.
Thanks for all your hard work everyone. Everything is well organized for the first pass. As of right now from what I can see we should get together at some point to talk about error handling and the address tab on the search is a little cramped on smaller devices. Overall, things we can worry about in polish stages.
blkfltchr
approved these changes
Jun 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merging days work into master