adding logic to handle KeyError: "Unable to open object (object 'connection table' doesn't exist)" on initial run #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dihm
requested changes
Oct 19, 2024
Contributor
dihm
left a comment
dihm
left a comment
There was a problem hiding this comment.
Couple nit-picks.
Actual change is small enough here that the white space changes aren't a problem (at some point we need to actually format all the source and add linting checks etc that would do these changes anyway).
Fixed try-except logic to be purely conditional to handle 'connection table' object not existing in apparatus settings h5 file
dihm
added a commit
that referenced
this pull request
Apr 29, 2025
commit d30739da328301cff1f0118c19f7d076b38d7628
Author: David Meyer <dihm@users.noreply.github.com>
Date: Fri Apr 11 13:39:06 2025 -0400
Merge pull request #108 from dihm/workflow_refresh
Workflow refresh
commit 3dd0df76623bb5cda36a43585b0749c097955ccf
Author: David Meyer <dihm@users.noreply.github.com>
Date: Mon Oct 21 11:15:12 2024 -0400
Merge pull request #107 from Json-To-String/master
adding logic to handle KeyError: "Unable to open object (object 'connection table' doesn't exist)" on initial run
commit 347d6bfc8c4f5e8c2775e336d505f896cb7fbdda
Author: David Meyer <dihm@users.noreply.github.com>
Date: Sat Jul 13 03:01:21 2024 -0400
Merge pull request #104 from dihm/metadata_overhaul
Metadata overhaul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a try, except block to ensure blacs/blacs/front_panel_settings.py does not attempt to access 'connection table' from the apparatus h5 file before it exists.
The commit for some reason has a decent bit of whitespace changes that were unintended, I can attempt to fix that but the main changes occur in front_panel_settings.py lines 76-84 and a comment explaining in lines 49-52.