From e88b6797ab18d78c8e801f2065f70c39b774753f Mon Sep 17 00:00:00 2001 From: James Goodhouse Date: Thu, 5 Dec 2019 12:52:59 -0800 Subject: [PATCH 1/2] Fix panic from not checking for nil --- session/session.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/session/session.go b/session/session.go index 4a0a726..afc7b5e 100644 --- a/session/session.go +++ b/session/session.go @@ -32,7 +32,11 @@ var ( // Get returns a named session. func Get(name string, c echo.Context) (*sessions.Session, error) { - store := c.Get(key).(sessions.Store) + s := c.Get(key) + if s == nil { + return nil, fmt.Errorf("%q session not found", name) + } + store := s.(sessions.Store) return store.Get(c.Request(), name) } From c8d0b6e082d428993c6dc2d1515ae319b13d43db Mon Sep 17 00:00:00 2001 From: James Goodhouse Date: Thu, 5 Dec 2019 13:07:48 -0800 Subject: [PATCH 2/2] add fmt package --- session/session.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/session/session.go b/session/session.go index afc7b5e..f041bc8 100644 --- a/session/session.go +++ b/session/session.go @@ -1,6 +1,8 @@ package session import ( + "fmt" + "github.com/gorilla/context" "github.com/gorilla/sessions" "github.com/labstack/echo/v4"