Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicated findStaticChild process at findChildWithLabel #2176

Merged
merged 1 commit into from May 27, 2022
Merged

fix: duplicated findStaticChild process at findChildWithLabel #2176

merged 1 commit into from May 27, 2022

Conversation

lkeix
Copy link
Contributor

@lkeix lkeix commented May 12, 2022

duplicated findStaticChild process at findChildWithLabel in router.go

I think less duplicate processing more readable except performance decrement.

@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #2176 (609021d) into master (6df1c35) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2176   +/-   ##
=======================================
  Coverage   92.20%   92.20%           
=======================================
  Files          37       37           
  Lines        3090     3090           
=======================================
  Hits         2849     2849           
  Misses        151      151           
  Partials       90       90           
Impacted Files Coverage Δ
router.go 96.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6df1c35...609021d. Read the comment docs.

@aldas aldas merged commit 0644cd6 into labstack:master May 27, 2022
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants