Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout mw: rework how test waits for timeout. Using sleep as delay i… #2187

Merged
merged 2 commits into from May 21, 2022

Conversation

aldas
Copy link
Contributor

@aldas aldas commented May 21, 2022

Timeout mw: rework how test waits for timeout. Using sleep as delay is problematic when CI worker is slower than usual. Also make sure we wait logger middleware to be actually executed before we start asserting logger buffer contents.

Still having problems with macos-latest @ Go 1.18 runs

2022-05-21 19:29:13.081172 +0000 UTC m=+0.616594200
--- FAIL: TestTimeoutWithFullEchoStack (0.14s)
    --- FAIL: TestTimeoutWithFullEchoStack/503_-_handler_timeouts,_write_response_in_timeout_middleware (0.08s)
        timeout_test.go:417: 
            	Error Trace:	timeout_test.go:417
            	Error:      	Should be false
            	Test:       	TestTimeoutWithFullEchoStack/503_-_handler_timeouts,_write_response_in_timeout_middleware

…s problematic when CI worker is slower than usual.
@aldas aldas force-pushed the fix_timeout_mw_fullstack_test branch from 051080b to a9c75d5 Compare May 21, 2022 20:36
…s problematic when CI worker is slower than usual.
@aldas aldas merged commit d5f8837 into labstack:master May 21, 2022
12 checks passed
@aldas aldas deleted the fix_timeout_mw_fullstack_test branch July 12, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant