Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middlewares should use errors.As() instead of type assertion on HTTPError #2227

Merged
merged 1 commit into from Jul 21, 2022

Conversation

danielbprice
Copy link

  • Helps consumers who want to wrap HTTPError, and other use cases

…rror

- Helps consumers who want to wrap HTTPError, and other use cases
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #2227 (59a0dc9) into master (70acd57) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2227   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files          37       37           
  Lines        3122     3123    +1     
=======================================
+ Hits         2883     2884    +1     
  Misses        150      150           
  Partials       89       89           
Impacted Files Coverage Δ
middleware/request_logger.go 97.61% <100.00%> (+0.02%) ⬆️
middleware/static.go 70.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70acd57...59a0dc9. Read the comment docs.

@aldas aldas merged commit a9879ff into labstack:master Jul 21, 2022
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants