Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2259 open redirect vulnerability in echo.StaticDirectoryHandler (used by e.Static, e.StaticFs etc) #2260

Merged
merged 1 commit into from Sep 4, 2022

Conversation

aldas
Copy link
Contributor

@aldas aldas commented Sep 4, 2022

Fix #2259 open redirect vulnerability in echo.StaticDirectoryHandler (used by e.Static, e.StaticFs etc)

Similar fix as #1771 had. path.Clean() could be alternative but potentially causes too much changes to path.

remove pre Go1.16 and after differences not to duplicate stuff anymore

…Handler (used by e.Static, e.StaticFs etc)

remove pre Go1.16 and after differences
@codecov
Copy link

codecov bot commented Sep 4, 2022

Codecov Report

Merging #2260 (3154abd) into master (d48197d) will decrease coverage by 0.04%.
The diff coverage is 84.95%.

@@            Coverage Diff             @@
##           master    #2260      +/-   ##
==========================================
- Coverage   92.40%   92.35%   -0.05%     
==========================================
  Files          37       37              
  Lines        4423     4436      +13     
==========================================
+ Hits         4087     4097      +10     
- Misses        245      247       +2     
- Partials       91       92       +1     
Impacted Files Coverage Δ
context_fs.go 78.57% <76.47%> (ø)
echo_fs.go 84.94% <84.70%> (ø)
group_fs.go 100.00% <100.00%> (ø)
middleware/csrf.go 89.42% <0.00%> (+0.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aldas aldas merged commit 0ac4d74 into labstack:master Sep 4, 2022
14 of 15 checks passed
@aldas aldas deleted the fix_2259_open_redirect branch December 29, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vulnerability: open redirect in static handler
1 participant