Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix func(Context) error to HandlerFunc #2315

merged 1 commit into from Nov 12, 2022

fix func(Context) error to HandlerFunc #2315

merged 1 commit into from Nov 12, 2022


Copy link

@lkeix lkeix commented Oct 25, 2022

HandlerFunc has already been defined as func(Context) error in echo.go.
I think using HandlerFunc is more smarter than func(Context) error!

Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 92.35% // Head: 92.35% // No change to project coverage 👍

Coverage data is based on head (48b2f2f) compared to base (8f2bf82).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2315   +/-   ##
  Coverage   92.35%   92.35%           
  Files          37       37           
  Lines        4436     4436           
  Hits         4097     4097           
  Misses        247      247           
  Partials       92       92           
Impacted Files Coverage Δ
echo.go 95.18% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aldas aldas merged commit a97d4bf into labstack:master Nov 12, 2022
@aldas aldas mentioned this pull request Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants